Code review comment for lp://staging/~seb128/update-manager/check-none-controller

Revision history for this message
Barry Warsaw (barry) wrote :

On Dec 11, 2013, at 09:06 AM, Sebastien Bacher wrote:

>> LGTM, though do you know of a way to reproduce the problem?
>
>no, I tried for a bit to trigger it but couldn't, the fix should be safe
>though since that's what was done before

Agreed, and by visual inspection it looked fine, so I committed it to trunk
and uploaded. Hey, that's what bug reports are for, right? :)

« Back to merge proposal