Software Updater

Merge lp://staging/~seb128/update-manager/check-none-controller into lp://staging/update-manager

  1. check-none-controller
  2. Merge into main
Proposed by Sebastien Bacher
Status: Merged
Approved by: Barry Warsaw
Approved revision: 2659
Merged at revision: 2659
Proposed branch: lp://staging/~seb128/update-manager/check-none-controller
Merge into: lp://staging/update-manager
Diff against target: 17 lines (+4/-3)
1 file modified
UpdateManager/UpdateManager.py (+4/-3)
To merge this branch: bzr merge lp://staging/~seb128/update-manager/check-none-controller
Reviewer Review Type Date Requested Status
Barry Warsaw (community) Approve
Michael Vogt Pending
Review via email: mp+197786@code.staging.launchpad.net

Commit message

check if there is a controller before using it

Description of the change

check if there is a controller before using it

that check was there before http://bazaar.launchpad.net/~ubuntu-core-dev/update-manager/main/revision/2622.1.7 and got dropped in the refactoring

To post a comment you must log in.
Revision history for this message
Barry Warsaw (barry) wrote :

LGTM, though do you know of a way to reproduce the problem?

Revision history for this message
Barry Warsaw (barry) :
review: Approve
Revision history for this message
Sebastien Bacher (seb128) wrote :

> LGTM, though do you know of a way to reproduce the problem?

no, I tried for a bit to trigger it but couldn't, the fix should be safe though since that's what was done before

Revision history for this message
Barry Warsaw (barry) wrote :

On Dec 11, 2013, at 09:06 AM, Sebastien Bacher wrote:

>> LGTM, though do you know of a way to reproduce the problem?
>
>no, I tried for a bit to trigger it but couldn't, the fix should be safe
>though since that's what was done before

Agreed, and by visual inspection it looked fine, so I committed it to trunk
and uploaded. Hey, that's what bug reports are for, right? :)

Revision history for this message
Sebastien Bacher (seb128) wrote :

> Agreed, and by visual inspection it looked fine, so I committed it to trunk
> and uploaded. Hey, that's what bug reports are for, right? :)

lol, indeed, thanks! ;-)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: