Code review comment for lp://staging/~ricmm/qtmir/delay-add-on-dash-start

Revision history for this message
Gerry Boland (gerboland) wrote :

The bad thing about this is that the UI does not respond to a user launching an application *immediately* - now the UI only reacts when the application launches and tries to authorize with Mir. As a result, app launching feels slightly slower.

I'd prefer we call add(application) as soon as possible.

This also does not behave well when a user-launched app fails to start (before authorizing) - the application will remain in m_startingApplications forever.

review: Needs Fixing

« Back to merge proposal