QtMir

Merge lp://staging/~ricmm/qtmir/delay-add-on-dash-start into lp://staging/qtmir

  1. delay-add-on-dash-start
  2. Merge into trunk
Proposed by Ricardo Mendoza
Status: Work in progress
Proposed branch: lp://staging/~ricmm/qtmir/delay-add-on-dash-start
Merge into: lp://staging/qtmir
Prerequisite: lp://staging/~gerboland/qtmir/lttng
Diff against target: 75 lines (+17/-2)
2 files modified
src/modules/Unity/Application/application_manager.cpp (+14/-2)
src/modules/Unity/Application/application_manager.h (+3/-0)
To merge this branch: bzr merge lp://staging/~ricmm/qtmir/delay-add-on-dash-start
Reviewer Review Type Date Requested Status
Gerry Boland (community) Needs Fixing
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+231602@code.staging.launchpad.net

Commit message

Delay adding Application to model when launching app from the Dash via url-dispatcher (for fast exec).

Description of the change

N.B. The same logic is not applied to the startApplication() method because this one is not in a blocking path for UAL's callbacks, therefore adding the Application to the model right away introduces no delays to the final exec()

(Savings are ~200ms)

To post a comment you must log in.
lp://staging/~ricmm/qtmir/delay-add-on-dash-start updated
239. By Ricardo Mendoza

Sync

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

There's some merge conflict leftovers in debian/changelog.

For the commit message we use the following format: a short summary (up to 80 or 90 chars) followed by an empty line and then a long description, if any.

Reply
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

> There's some merge conflict leftovers in debian/changelog.

Ah, you're actually removing them. Nevermind
Must be due to the prerequisite...

Reply
lp://staging/~ricmm/qtmir/delay-add-on-dash-start updated
240. By Ricardo Mendoza

Merge lttng

241. By Ricardo Mendoza

Fix

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:239
http://jenkins.qa.ubuntu.com/job/qtmir-ci/22/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-utopic-amd64-ci/22/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-utopic-armhf-ci/22/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/22/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:241
http://jenkins.qa.ubuntu.com/job/qtmir-ci/24/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-utopic-amd64-ci/24/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-utopic-armhf-ci/24/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/24/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Gerry Boland (gerboland) wrote :

The bad thing about this is that the UI does not respond to a user launching an application *immediately* - now the UI only reacts when the application launches and tries to authorize with Mir. As a result, app launching feels slightly slower.

I'd prefer we call add(application) as soon as possible.

This also does not behave well when a user-launched app fails to start (before authorizing) - the application will remain in m_startingApplications forever.

review: Needs Fixing
Reply

Unmerged revisions

241. By Ricardo Mendoza

Fix

240. By Ricardo Mendoza

Merge lttng

239. By Ricardo Mendoza

Sync

238. By Ricardo Mendoza

Delay adding Application to model when in app launch fast-path (launched from Dash by url-dispatcher)

237. By Ricardo Mendoza

Merge lp:~gerboland/qtmir/lttng

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches