Code review comment for lp://staging/~ralsina/tanuki-agent/warn-empty

Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

Hi,

So you actually want to test two things:

1) That warn_empty_config_values works as expected - a unit test.

2) That the application calls warn_empty_config_values on startup - an integration test.

If that's the case, then these really should be separate tests. Doing so gives us cleaner separation of concerns, a faster test suite, and less reliance on mocking.

« Back to merge proposal