tanuki-agent

Merge lp://staging/~ralsina/tanuki-agent/warn-empty into lp://staging/tanuki-agent

warn-empty
Merge into trunk

Proposed by Roberto Alsina on 2015-08-31

Status:	Merged
Approved by:	Roberto Alsina on 2015-09-09
Approved revision:	84
Merged at revision:	82
Proposed branch:	lp://staging/~ralsina/tanuki-agent/warn-empty
Merge into:	lp://staging/tanuki-agent
Diff against target:	46 lines (+26/-0) 2 files modified agent.py (+9/-0) test_agent.py (+17/-0)
To merge this branch:	bzr merge lp://staging/~ralsina/tanuki-agent/warn-empty
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Thomi Richards (community)		2015-08-31	Approve on 2015-09-08
Review via email: mp+269642@code.staging.launchpad.net

Commit message

Warn the user if configuration options are empty.

Description of the change

Warn the user if configuration options are empty.

lp://staging/~ralsina/tanuki-agent/warn-empty updated on 2015-08-31

83. By Roberto Alsina on 2015-08-31: typo

Revision history for this message

Thomi Richards (thomir-deactivatedaccount) wrote on 2015-08-31:

I think restructuring this to remove the instance method is worth doing - see diff comments.

review: Needs Fixing

Revision history for this message

Roberto Alsina (ralsina) wrote on 2015-08-31:

I would prefer to keep the test as-is because I want to test that instantiating agent with empty config keys warns, not only that the warn_empty_config_values function works.

Revision history for this message

Thomi Richards (thomir-deactivatedaccount) wrote on 2015-09-02:

Hi,

So you actually want to test two things:

1) That warn_empty_config_values works as expected - a unit test.

2) That the application calls warn_empty_config_values on startup - an integration test.

If that's the case, then these really should be separate tests. Doing so gives us cleaner separation of concerns, a faster test suite, and less reliance on mocking.

lp://staging/~ralsina/tanuki-agent/warn-empty updated on 2015-09-02