Code review comment for ~racb/git-ubuntu:prepare-upload-adjustments

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

LGTM!

At first I wondered if it would be a good idea to verify the contents of the "headers" dict in "cli_printargs", but then I realized it is already being done in "push" (even though that is being done through calls to "assert" and therefore we do rely on __debug__ being set to True).

review: Approve

« Back to merge proposal