Code review comment for ~racb/git-ubuntu:rich-history-from-changes-file

Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks, the updates look good and answers to all the questions sound fine.
I did one more code review pass and didn't spot anything to mention.

They critical piece for this patch is the filtration of potential malicious input. It looks like more than enough thought has gone into this versus the (probably low) level of risk we're likely to see in practice.

LGTM, +1.

review: Approve

« Back to merge proposal