git-ubuntu

Merge ~racb/git-ubuntu:changelog-date-override into git-ubuntu:master

  1. Git
  2. lp:~racb/git-ubuntu
  3. changelog-date-override
  4. Merge into master
Proposed by Robie Basak
Status: Merged
Merged at revision: 649af7b2880946e75563f7a28c9343af2be64315
Proposed branch: ~racb/git-ubuntu:changelog-date-override
Merge into: git-ubuntu:master
Diff against target: 519 lines (+210/-17)
7 files modified
gitubuntu/__main__.py (+11/-0)
gitubuntu/changelog_date_overrides.txt (+10/-0)
gitubuntu/git_repository.py (+18/-10)
gitubuntu/git_repository_test.py (+2/-2)
gitubuntu/importer.py (+87/-3)
gitubuntu/importer_test.py (+73/-0)
gitubuntu/source_builder.py (+9/-2)
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Approve
Bryce Harrington Approve
Review via email: mp+388678@code.staging.launchpad.net

Commit message

Make Jenkins happy

To post a comment you must log in.
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:6786dc742ab95448251d5e0e3ecaf9ffae8caefc
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/537/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: Unit Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/537//rebuild

review: Approve (continuous-integration)
Revision history for this message
Bryce Harrington (bryce) wrote :

d7fdf25872d485051b3810186770a046f81673ef
  + LGTM

276593d61b624b58fd75e5b7f0597d13f93473cb
  + LGTM

6786dc742ab95448251d5e0e3ecaf9ffae8caefc
  + Why is the help for --changelog-date-override-file suppressed?

  + Couldn't help but copyedit a few of the parameter docs, nothing major just grammar tweaking:

    :param str changelog_date_override_file: if specified, the
        path to a file specifying versions of packages with
        changelog dates that should be ignored. The publishing
        date of the source package data instance should be used
        instead. See parse_changelog_date_overrides() for the
        required format of the file.

    :param datetime.datetime author_date: Overrides the author
        date normally parsed from the changelog entry (i.e. for
        handling date parsing edge cases). Any sub-second part of
        the timestamp is truncated.

    :param frozenset(str) changelog_date_overrides: Versions from
        the changelog where the changelog's date should be ignored,
        and the commit date to be used instead. See the docstring of
        parse_changelog_date_overrides() for details.

Beyond that, everything else looks pretty straightforward.

review: Approve
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

FAILED: Continuous integration, rev:39f34dd73b4201b5824499bca207379d601fead9
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/538/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    FAILED: Unit Tests

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/538//rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:649af7b2880946e75563f7a28c9343af2be64315
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/539/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: Unit Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/539//rebuild

review: Approve (continuous-integration)
Revision history for this message
Robie Basak (racb) wrote :

> 6786dc742ab95448251d5e0e3ecaf9ffae8caefc
> + Why is the help for --changelog-date-override-file suppressed?

I followed the same pattern as already exist for the other override files. I agree this is suboptimal but didn't want to go down that rabbit hole for this MP.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches