Code review comment for ~racb/git-ubuntu:changelog-date-override

Revision history for this message
Bryce Harrington (bryce) wrote :

d7fdf25872d485051b3810186770a046f81673ef
  + LGTM

276593d61b624b58fd75e5b7f0597d13f93473cb
  + LGTM

6786dc742ab95448251d5e0e3ecaf9ffae8caefc
  + Why is the help for --changelog-date-override-file suppressed?

  + Couldn't help but copyedit a few of the parameter docs, nothing major just grammar tweaking:

    :param str changelog_date_override_file: if specified, the
        path to a file specifying versions of packages with
        changelog dates that should be ignored. The publishing
        date of the source package data instance should be used
        instead. See parse_changelog_date_overrides() for the
        required format of the file.

    :param datetime.datetime author_date: Overrides the author
        date normally parsed from the changelog entry (i.e. for
        handling date parsing edge cases). Any sub-second part of
        the timestamp is truncated.

    :param frozenset(str) changelog_date_overrides: Versions from
        the changelog where the changelog's date should be ignored,
        and the commit date to be used instead. See the docstring of
        parse_changelog_date_overrides() for details.

Beyond that, everything else looks pretty straightforward.

review: Approve

« Back to merge proposal