Code review comment for lp://staging/~pwlars/ubuntu-ci-services-itself/image-builder-deploy

Revision history for this message
Andy Doan (doanac) wrote :

welcome to juju! only one minor comment. technically speaking this line isn't needed:

14 + packages: "python-webtest python-mock python-jinja2"

because the charm already defaults to that list of packages:

http://bazaar.launchpad.net/~canonical-ci-engineering/charms/precise/ubuntu-ci-services-itself/restish/view/head:/config.yaml#L11

However, your needs may change in the future so it might not be worth removing this line now, and then adding it back next week.

+1 regardless of your choice.

review: Approve

« Back to merge proposal