Ubuntu CI Services

Merge lp://staging/~pwlars/ubuntu-ci-services-itself/image-builder-deploy into lp://staging/ubuntu-ci-services-itself

  1. image-builder-deploy
  2. Merge into trunk
Proposed by Paul Larson
Status: Merged
Approved by: Francis Ginther
Approved revision: 41
Merged at revision: 44
Proposed branch: lp://staging/~pwlars/ubuntu-ci-services-itself/image-builder-deploy
Merge into: lp://staging/ubuntu-ci-services-itself
Diff against target: 21 lines (+17/-0)
1 file modified
juju-deployer/image-builder.yaml (+17/-0)
To merge this branch: bzr merge lp://staging/~pwlars/ubuntu-ci-services-itself/image-builder-deploy
Reviewer Review Type Date Requested Status
Francis Ginther Approve
Andy Doan (community) Approve
Review via email: mp+199318@code.staging.launchpad.net

Commit message

Add a juju-deployer yaml for image-builder

Description of the change

Add a juju-deployer yaml for image-builder

To post a comment you must log in.
Revision history for this message
Andy Doan (doanac) wrote :

welcome to juju! only one minor comment. technically speaking this line isn't needed:

14 + packages: "python-webtest python-mock python-jinja2"

because the charm already defaults to that list of packages:

http://bazaar.launchpad.net/~canonical-ci-engineering/charms/precise/ubuntu-ci-services-itself/restish/view/head:/config.yaml#L11

However, your needs may change in the future so it might not be worth removing this line now, and then adding it back next week.

+1 regardless of your choice.

review: Approve
Revision history for this message
Paul Larson (pwlars) wrote :

I'm probably going to need the amqplib and possibly a few other
things, so I went ahead and put it there as a placeholder. Good to
know though.

On Tue, Dec 17, 2013 at 10:51 AM, Andy Doan <email address hidden> wrote:
> Review: Approve
>
> welcome to juju! only one minor comment. technically speaking this line isn't needed:
>
> 14 + packages: "python-webtest python-mock python-jinja2"
>
> because the charm already defaults to that list of packages:
>
> http://bazaar.launchpad.net/~canonical-ci-engineering/charms/precise/ubuntu-ci-services-itself/restish/view/head:/config.yaml#L11
>
> However, your needs may change in the future so it might not be worth removing this line now, and then adding it back next week.
>
> +1 regardless of your choice.
> --
> https://code.launchpad.net/~pwlars/ubuntu-ci-services-itself/image-builder-deploy/+merge/199318
> You are the owner of lp:~pwlars/ubuntu-ci-services-itself/image-builder-deploy.

Revision history for this message
Francis Ginther (fginther) wrote :

Tested that deploy works.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches