Linaro Android Build Tools

Merge lp://staging/~pundiramit/linaro-android-build-tools/labc_1304 into lp://staging/linaro-android-build-tools

labc_1304
Merge into trunk

Proposed by Amit Pundir on 2013-05-17

Status:	Merged
Approved by:	Paul Sokolovsky on 2013-05-23
Approved revision:	620
Merged at revision:	615
Proposed branch:	lp://staging/~pundiramit/linaro-android-build-tools/labc_1304
Merge into:	lp://staging/linaro-android-build-tools
Diff against target:	92 lines (+41/-20) 1 file modified build-scripts/create-user-build-script (+41/-20)
To merge this branch:	bzr merge lp://staging/~pundiramit/linaro-android-build-tools/labc_1304
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Paul Sokolovsky	2013-05-17	Approve on 2013-05-23
Linaro Automation & Validation	2013-05-22	Pending
Review via email: mp+164343@code.staging.launchpad.net

Description of the change

Export perf build variable from android-build.linaro.org build configuration.
Support 13.04 build machines.
Reworked on broken dependencies of 12.04 and 10.04.
Verified on 10.04, 12.04, 12.10 and 13.04 chrooted environment.

Revision history for this message

Paul Sokolovsky (pfalcon) wrote on 2013-05-22:

I'd say that it get's harder and harder to follow thru the logic here - it clearly calls for some refactoring, for example instead all the repeating "[ \`dpkg-query -W -f='\${Status}\n' python-software-properties 2>&1 | grep -i 'No packages found matching' | wc -l\` -gt 0 ]", there would rather be "function is_package_installed()".

But ok, you guys maintain that script, so it's up to whether to refactor it now. No problems android build system wise.

review: Approve

lp://staging/~pundiramit/linaro-android-build-tools/labc_1304 updated on 2013-05-22

615. By Amit Pundir on 2013-05-22: create-user-build-script: cleanup and few dependency fixes
616. By Amit Pundir on 2013-05-22: create-user-build-script: some more clean-up

Revision history for this message

Amit Pundir (pundiramit) wrote on 2013-05-22:

Paul,

See if the following changes are good to go.
Also let me know if I need to use ESCAPE character for "^".

lp://staging/~pundiramit/linaro-android-build-tools/labc_1304 updated on 2013-05-23

617. By Amit Pundir on 2013-05-23: create-user-build-script: export Juice build variables from android-build config
618. By Amit Pundir on 2013-05-23: create-user-build-script: remove check missing dependencies part and do forceful repo sync to recover on broken/missing objects
619. By Amit Pundir on 2013-05-23: create-user-build-script: remove check missing dependencies part and do forceful repo sync to recover on broken/missing objects
620. By Amit Pundir on 2013-05-23: create-user-build-script: remove 10.04.* HOST machines from the list of supported build machines

Revision history for this message

Paul Sokolovsky (pfalcon) wrote on 2013-05-23:

Thanks for doing the cleanups, latest version looks much more regular and readable. I also don't see any "^" in the latest patch, so I assume that issue was resolved too. Will merge.

review: Approve