Code review comment for lp://staging/~pundiramit/linaro-android-build-tools/labc_1304

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

I'd say that it get's harder and harder to follow thru the logic here - it clearly calls for some refactoring, for example instead all the repeating "[ \`dpkg-query -W -f='\${Status}\n' python-software-properties 2>&1 | grep -i 'No packages found matching' | wc -l\` -gt 0 ]", there would rather be "function is_package_installed()".

But ok, you guys maintain that script, so it's up to whether to refactor it now. No problems android build system wise.

review: Approve

« Back to merge proposal