Code review comment for lp://staging/~pkunal-parmar/ubuntu-calendar-app/CalManagement

Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

> 56 + for(var i=0; i < collections.length ; ++i) {
> 57 + var collection = collections[i]
> 58 + if(collection.extendedMetaData("collection-
> selected") === true) {
> 59 +
> collectionIds.push(collection.collectionId);
> 60 + }
> 61 + }
>
> Should you save even if the collection is un-selected? In case of the user un-
> select the collection, and want to save that state?

Sorry, my bad. Now I understand you are creating the filter.

« Back to merge proposal