Merge lp://staging/~pkunal-parmar/ubuntu-calendar-app/CalManagement into lp://staging/ubuntu-calendar-app

FAILED: Continuous integration, rev:215
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/347/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-trusty/1914
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/347
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/347
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-trusty-amd64-ci/181

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/347/rebuild

FAILED: Continuous integration, rev:216
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/348/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-trusty/1915
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/348
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/348
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-trusty-amd64-ci/182

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/348/rebuild

FAILED: Continuous integration, rev:217
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/350/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-trusty/1917
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/350
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/350
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-trusty-amd64-ci/184

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/350/rebuild

I don't understand why this fails in Jenkins. Will ask fginther to review.

The links qtorganizer5-eds MP has been approved now

PASSED: Continuous integration, rev:220
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/367/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-trusty/1983
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/367
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/367
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-trusty-amd64-ci/201

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/367/rebuild

PASSED: Continuous integration, rev:221
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/368/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-trusty/1984
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/368
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/368
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-trusty-amd64-ci/202

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/368/rebuild

FAILED: Continuous integration, rev:222
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/378/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2010
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/378
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/378
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-trusty-amd64-ci/212

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/378/rebuild

I get the same failure on the device as Jenkins sees:

Traceback (most recent call last):
File "/home/phablet/autopilot/calendar_app/tests/test_calendar.py", line 94, in test_new_event
self.main_view.open_toolbar().click_button("todaybutton")
File "/usr/lib/python3/dist-packages/autopilot/logging.py", line 46, in inner
return f(instance, *args, **kwargs)
File "/usr/lib/python3/dist-packages/ubuntuuitoolkit/emulators.py", line 294, in click_button
'Button with objectName "{0}" not found.'.format(object_name))
ubuntuuitoolkit.emulators.ToolkitEmulatorException: Button with objectName "todaybutton" not found.

I also get this failure on the device:

======================================================================
ERROR: unittest.loader.ModuleImportFailure.calendar_app.tests.test_monthview
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/autopilot/run.py", line 420, in _filter_tests
test.debug()
File "/usr/lib/python3.4/unittest/case.py", line 627, in debug
getattr(self, self._testMethodName)()
File "/usr/lib/python3.4/unittest/loader.py", line 32, in testFailure
raise exception
ImportError: Failed to import test module: calendar_app.tests.test_monthview
Traceback (most recent call last):
File "/usr/lib/python3.4/unittest/loader.py", line 312, in _find_tests
module = self._get_module_from_name(name)
File "/usr/lib/python3.4/unittest/loader.py", line 290, in _get_module_from_name
__import__(name)
File "/home/phablet/autopilot/calendar_app/tests/test_monthview.py", line 20, in <module>
from dateutil.relativedelta import relativedelta
ImportError: No module named 'dateutil'

> File "/home/phablet/autopilot/calendar_app/tests/test_monthview.py", line 20, in <module>
from dateutil.relativedelta import relativedelta
ImportError: No module named 'dateutil'

For this, I think you need to install dateutil python module.

>'Button with objectName "{0}" not found.'.format(object_name))
ubuntuuitoolkit.emulators.ToolkitEmulatorException: Button with objectName "todaybutton" not found.

I am not sure why its not able to find todayButton.

BTW if you have some suggestion for colors in Calendar's Color, that we can use, please do, I will add those to color picker.

Thanks, yep, installing python-dateutil fixed the first issue.

I'll look a bit into the second issue.

Tested on mako, worked well. Only improvement I can see is maybe reducing the font size in the calendar list as they all seem too large to me and run into the tickbox.

56 + for(var i=0; i < collections.length ; ++i) {
57 + var collection = collections[i]
58 + if(collection.extendedMetaData("collection-selected") === true) {
59 + collectionIds.push(collection.collectionId);
60 + }
61 + }

Should you save even if the collection is un-selected? In case of the user un-select the collection, and want to save that state?

> 56 + for(var i=0; i < collections.length ; ++i) {
> 57 + var collection = collections[i]
> 58 + if(collection.extendedMetaData("collection-
> selected") === true) {
> 59 +
> collectionIds.push(collection.collectionId);
> 60 + }
> 61 + }
>
> Should you save even if the collection is un-selected? In case of the user un-
> select the collection, and want to save that state?

Sorry, my bad. Now I understand you are creating the filter.

Just a opinion here:
53 + onTriggered: {
54 + var collectionIds = [];
55 + var collections = calendarsList.model;
56 + for(var i=0; i < collections.length ; ++i) {
57 + var collection = collections[i]
58 + if(collection.extendedMetaData("collection-selected") === true) {
59 + collectionIds.push(collection.collectionId);
60 + }
61 + }
62 +
63 + var calFilter = Qt.createQmlObject("import QtOrganizer 5.0; CollectionFilter{}", root, "CalendarChoice.qml");
64 + calFilter.ids = collectionIds;
65 + model.filter = calFilter;
66 + pageStack.pop();
67 + }

This will be more QML "friendly" :D if you do something like:

53 + onTriggered: {
54 + var collectionIds = []
55 + var collections = calendarsList.model;
56 + for(var i=0; i < collections.length ; ++i) {
57 + var collection = collections[i]
58 + if(collection.extendedMetaData("collection-selected") === true) {
59 + collectionIds.push(collection.collectionId);
60 + }
61 + }
65 + model.filter.ids = collectionIds;
66 + pageStack.pop();
67 + }

Should not be necessary to recreate the filter every time, you can use the old filter instead.

Where do you save the collection after the user select or unselect it?
This should be saved back in the model.

FAILED: Continuous integration, rev:222
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/395/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2126/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/395/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/395/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-trusty-amd64-ci/229/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/395/rebuild

The reason the test is failing is because new events aren't saving properly. Try running the app and making a new event. It doesn't leave the new event screen, no matter how much I press 'save' :-)

Just affirming trunk does not suffer from this issue. New events can be properly saved.

> Tested on mako, worked well. Only improvement I can see is maybe reducing the
> font size in the calendar list as they all seem too large to me and run into
> the tickbox.

ok, will change font to meduim

> Where do you save the collection after the user select or unselect it?
> This should be saved back in the model.

If user change the color then I save collection like this

136 + var collection = root.model.collection(modelData.collectionId);
137 + collection.color = color;
138 + root.model.saveCollection(collection);
139 + })

But if user just select and unselect the collection for filtering event. I just do the following.

152 + onCheckedChanged: {
153 + modelData.setExtendedMetaData("collection-selected",checkBox.checked)
154 + }

Ok, but if the user quit the app and open again? The selected
calendars will be different since you did not save the options.

On Wed, Apr 16, 2014 at 10:12 AM, Kunal Parmar <email address hidden> wrote:
>> Where do you save the collection after the user select or unselect it?
>> This should be saved back in the model.
>
> If user change the color then I save collection like this
>
> 136 + var collection = root.model.collection(modelData.collectionId);
> 137 + collection.color = color;
> 138 + root.model.saveCollection(collection);
> 139 + })
>
> But if user just select and unselect the collection for filtering event. I just do the following.
>
> 152 + onCheckedChanged: {
> 153 + modelData.setExtendedMetaData("collection-selected",checkBox.checked)
> 154 + }
> --
> https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/CalManagement/+merge/213355
> You are requested to review the proposed merge of lp:~pkunal-parmar/ubuntu-calendar-app/CalManagement into lp:ubuntu-calendar-app.

> Ok, but if the user quit the app and open again? The selected
> calendars will be different since you did not save the options.

Ok, Then I will save collection when user select/unselect checkbox.
Thanks for pointing it out.

FAILED: Continuous integration, rev:225
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/397/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2149
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/397
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/397
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-trusty-amd64-ci/231

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/397/rebuild

FAILED: Continuous integration, rev:227
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/398/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2150
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/398
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/398
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-trusty-amd64-ci/232

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/398/rebuild

The crash looks like qtpim related to me after doing some debugging. https://codereview.qt-project.org/#change,83696

looks good

I built a package including Albert's patch

https://launchpad.net/~popey/+archive/qtpim/+build/5916407

Have you had a chance to test with the "fixed" qtpim from my ppa?

> Have you had a chance to test with the "fixed" qtpim from my ppa?

I tested, but I don't see any difference. I will try once again after system update.

Is this blocking on something else? Do we need to get Albert or upstream Qt involved?

Changing review as Needs Information as per the last comments

I have asked Albert if he can help us debug the crash which is easily reproducible with this branch:-

Grab this branch
Add this ppa https://launchpad.net/~popey/+archive/qtpim and update/upgrade
In system system-settings -> online accounts I have 2x google accounts (one personal, one work) which I enabled calendar sync on. (I have also tried with only one account active).
Start the calendar app with qmlscene calendar.qml
After a short while navigating around it crashes:-

(qmlscene:21334): GLib-GObject-CRITICAL **: g_object_unref: assertion
'G_IS_OBJECT (object)' failed
Segmentation fault (core dumped)

It crashes on Utopic image as well on device

Albert ran this under valgrind and found it's still crashing in qtorganized-eds

==16142== Invalid write of size 8
==16142== at 0x230989DA: RequestData::cancel() (in /usr/lib/x86_64-linux-gnu/qt5/plugins/organizer/libqtorganizer_eds.so)
==16142== by 0x2308858A: QOrganizerEDSEngine::cancelRequest(QtOrganizer::QOrganizerAbstractRequest*) (in /usr/lib/x86_64-linux-gnu/qt5/plugins/organizer/libqtorganizer_eds.so)
==16142== by 0x1EC266FA: QtOrganizer::QOrganizerAbstractRequest::cancel() (in /usr/lib/x86_64-linux-gnu/libQt5Organizer.so.5.0.0)
==16142== by 0x21F3A322: ??? (in /usr/lib/x86_64-linux-gnu/qt5/qml/QtOrganizer/libdeclarative_organizer.so)
==16142== by 0x21F3AA53: ??? (in /usr/lib/x86_64-linux-gnu/qt5/qml/QtOrganizer/libdeclarative_organizer.so)
==16142== by 0x21F42DC4: ??? (in /usr/lib/x86_64-linux-gnu/qt5/qml/QtOrganizer/libdeclarative_organizer.so)
==16142== by 0x6ACF22D: QObject::event(QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.2.1)
==16142== by 0x5B03C8B: QApplicationPrivate::notify_helper(QObject*, QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.2.1)
==16142== by 0x5B08E55: QApplication::notify(QObject*, QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.2.1)
==16142== by 0x6AA6C2C: QCoreApplication::notifyInternal(QObject*, QEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.2.1)
==16142== by 0x6AA8E06: QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.2.1)
==16142== by 0x6AF3CD2: ??? (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.2.1)
==16142== Address 0x33ab75c8 is 56 bytes inside a block of size 96 free'd
==16142== at 0x4C2C2BC: operator delete(void*) (vg_replace_malloc.c:503)
==16142== by 0x23314374: ??? (in /usr/lib/libecal-1.2.so.16.0.0)
==16142== by 0x23319FA1: ??? (in /usr/lib/libecal-1.2.so.16.0.0)
==16142== by 0x1410EEF6: g_simple_async_result_complete (in /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0.4000.0)
==16142== by 0x1410EF78: complete_in_idle_cb_for_thread (in /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0.4000.0)
==16142== by 0x831DCE4: g_main_context_dispatch (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4000.0)
==16142== by 0x831E047: g_main_context_iterate.isra.24 (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4000.0)
==16142== by 0x831E0EB: g_main_context_iteration (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4000.0)
==16142== by 0x6AF398B: QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.2.1)
==16142== by 0x23085FC6: QOrganizerEDSEngine::waitForRequestFinished(QtOrganizer::QOrganizerAbstractRequest*, int) (in /usr/lib/x86_64-linux-gnu/qt5/plugins/organizer/libqtorganizer_eds.so)
==16142== by 0x230989D9: RequestData::cancel() (in /usr/lib/x86_64-linux-gnu/qt5/plugins/organizer/libqtorganizer_eds.so)
==16142== by 0x2308858A: QOrganizerEDSEngine::cancelRequest(QtOrganizer::QOrganizerAbstractRequest*) (in /usr/lib/x86_64-linux-gnu/qt5/plugins/organizer/libqtorganizer_eds.so)

To reproduce

#plug phone in
bzr branch lp:~pkunal-parmar/ubuntu-calendar-app/CalManagement ./ubuntu-calendar-app
click-buddy --dir ubuntu-calendar-app/ --provision
# Setup google account(s) on device and enable calendar sync on them
# Let sync monitor do its thing
# Open calendar app
# Open Calendar management from the bottom toolbar.

I was unable to reproduce the same crash, using popey steps I go a different crash as you can see in the log bellow:

#1 0xb0d50a50 in ~QDeclarativeOrganizerModelPrivate (this=0x6c4ce0, __in_chrg=<optimized out>) at qdeclarativeorganizermodel.cpp:115
#2 cleanup (pointer=0x6c4ce0) at /usr/include/qt5/QtCore/qscopedpointer.h:62
#3 ~QScopedPointer (this=0x6c4c30, __in_chrg=<optimized out>) at /usr/include/qt5/QtCore/qscopedpointer.h:109
#4 QDeclarativeOrganizerModel::~QDeclarativeOrganizerModel (this=0x6c4c20, __in_chrg=<optimized out>) at qdeclarativeorganizermodel.cpp:209
#5 0xb0d311fc in ~QQmlElement (this=0x6c4c20, __in_chrg=<optimized out>) at /usr/include/qt5/QtQml/qqmlprivate.h:90
#6 QQmlPrivate::QQmlElement<QDeclarativeOrganizerModel>::~QQmlElement (this=0x6c4c20, __in_chrg=<optimized out>) at /usr/include/qt5/QtQml/qqmlprivate.h:90
#7 0xb6371da0 in QObjectPrivate::deleteChildren (this=this@entry=0x619110) at kernel/qobject.cpp:1841
#8 0xb6375fee in QObject::~QObject (this=<optimized out>, __in_chrg=<optimized out>) at kernel/qobject.cpp:934
#9 0xb6ea4588 in QQuickItem::~QQuickItem (this=0x6190b0, __in_chrg=<optimized out>) at items/qquickitem.cpp:2038
#10 0xb6f098e2 in ~QQuickImplicitSizeItem (this=0x6190b0, __in_chrg=<optimized out>) at items/qquickimplicitsizeitem_p.h:51
#11 QQuickLoader::~QQuickLoader (this=0x6190b0, __in_chrg=<optimized out>) at items/qquickloader.cpp:311
#12 0xb6eb1950 in ~QQmlElement (this=0x6190b0, __in_chrg=<optimized out>) at ../../include/QtQml/../../src/qml/qml/qqmlprivate.h:90
#13 QQmlPrivate::QQmlElement<QQuickLoader>::~QQmlElement (this=0x6190b0, __in_chrg=<optimized out>) at ../../include/QtQml/../../src/qml/qml/qqmlprivate.h:90
#14 0xb6371da0 in QObjectPrivate::deleteChildren (this=this@entry=0x618e60) at kernel/qobject.cpp:1841
#15 0xb6375fee in QObject::~QObject (this=<optimized out>, __in_chrg=<optimized out>) at kernel/qobject.cpp:934
#16 0xb6ea4588 in QQuickItem::~QQuickItem (this=0x618b58, __in_chrg=<optimized out>) at items/qquickitem.cpp:2038
#17 0xb6eb10cc in ~QQmlElement (this=0x618b58, __in_chrg=<optimized out>) at ../../include/QtQml/../../src/qml/qml/qqmlprivate.h:90
#18 QQmlPrivate::QQmlElement<QQuickItem>::~QQmlElement (this=0x618b58, __in_chrg=<optimized out>) at ../../include/QtQml/../../src/qml/qml/qqmlprivate.h:90
#19 0xb6d467f6 in QQmlDelegateModel::~QQmlDelegateModel (this=0x55d1b8, __in_chrg=<optimized out>) at types/qqmldelegatemodel.cpp:236
#20 0xb6d4686c in QQmlDelegateModel::~QQmlDelegateModel (this=0x55d1b8, __in_chrg=<optimized out>) at types/qqmldelegatemodel.cpp:250
#21 0xb6f02894 in QQuickPathView::~QQuickPathView (this=0x55c638, __in_chrg=<optimized out>) at items/qquickpathview.cpp:558
#22 0xb6eb1830 in ~QQmlElement (this=0x55c638, __in_chrg=<optimized out>) at ../../include/QtQml/../../src/qml/qml/qqmlprivate.h:90
#23 QQmlPrivate::QQmlElement<QQuickPathView>::~QQmlElement (this=0x55c638, __in_chrg=<optimized out>) at ../../include/QtQml/../../src/qml/qml/qqmlprivate.h:90
#24 0xb6371da0 in QObjectPrivate::deleteChildren (this=this@entry=0x554cf0) at kernel/qobject.cpp:1841
#25 0xb6375fee in QObject::~QObject (this=<optimized out>, __in_chrg=<optimized out>) at ke...

Build a fresh new version of qtpim git fixes the crash, I was unable to reproduce it after install the new version.

But even after that I did some changes on EDS plugin that could cause the crash described on popey log.

The MR can be found here: https://code.launchpad.net/~renatofilho/qtorganizer5-eds/fix-engine-crash/+merge/219586

Tested this branch with the following ppa enabled as requested by renato. https://launchpad.net/~canonical-qt5-edgers/+archive/qt5-proper/+packages

It all seems to work, I had no crashes. The only big issue is performance. With my personal and work calendars enabled the evolution-calendar-factory process was pegging at 100% a lot of the time when navigating from one screen to another.

The way I tested that was:-

# plug phone in
adb shell touch /userdata/.writable_image
adb reboot
adb shell

# on phone
add-apt-repository ppa:canonical-qt5-edgers/qt5-proper
apt-get update
apt-get upgrade

CTRL+D
adb reboot

# Test

FAILED: Continuous integration, rev:229
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/463/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2689
        deb: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2689/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/226
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/226/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-trusty-amd64-ci/297
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/21

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/463/rebuild

FAILED: Continuous integration, rev:231
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/464/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2690
        deb: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2690/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/227
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/227/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-trusty-amd64-ci/298
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/22

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/464/rebuild

FAILED: Continuous integration, rev:232
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/466/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2692
        deb: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2692/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/229
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/229/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-trusty-amd64-ci/300
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/24

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/466/rebuild

#blocked on EDS crashes

FAILED: Continuous integration, rev:235
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/487/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2788
        deb: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2788/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/325
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/325/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-trusty-amd64-ci/321
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/45

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/487/rebuild

FAILED: Continuous integration, rev:237
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/491/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2813
        deb: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2813/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/350
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/350/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-trusty-amd64-ci/325
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/49

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/491/rebuild

looks like we need some policy rules:

Fail to update collection An AppArmor policy prevents this sender from sending this message to this recipient, 0 matched rules; type="method_call", sender=":1.99" (uid=32011 pid=4871 comm="/usr/lib/arm-linux-gnueabihf/qt5/bin/qmlscene cale") interface="org.gnome.evolution.dataserver.Source.Writable" member="Write" error name="(unset)" requested_reply="0" destination=":1.38" (uid=32011 pid=2073 comm="/usr/lib/evolution/evolution-source-registry ")
Fail to update collection An AppArmor policy prevents this sender from sending this message to this recipient, 0 matched rules; type="method_call", sender=":1.99" (uid=32011 pid=4871 comm="/usr/lib/arm-linux-gnueabihf/qt5/bin/qmlscene cale") interface="org.gnome.evolution.dataserver.Source.Writable" member="Write" error name="(unset)" requested_reply="0" destination=":1.38" (uid=32011 pid=2073 comm="/usr/lib/evolution/evolution-source-registry ")

There are a number of apparmor rules for the calendar already-- can you paste the output of 'grep DEN /var/log/syslog' at the time of the denial?

Jun 3 17:55:12 ubuntu-phablet dbus[1547]: apparmor="DENIED" operation="dbus_method_call" bus="session" path="/org/gnome/evolution/dataserver/SourceManager/Source_12" interface="org.gnome.evolution.dataserver.Source.Writable" member="Write" mask="send" name=":1.42" pid=17983 profile="com.ubuntu.calendar_calendar_0.4.237" peer_pid=2557 peer_profile="unconfined"
Jun 3 17:55:12 ubuntu-phablet dbus[1547]: apparmor="DENIED" operation="dbus_method_call" bus="session" path="/org/gnome/evolution/dataserver/SourceManager/Source_8" interface="org.gnome.evolution.dataserver.Source.Writable" member="Write" mask="send" name=":1.42" pid=17983 profile="com.ubuntu.calendar_calendar_0.4.237" peer_pid=2557 peer_profile="unconfined"
Jun 3 17:55:17 ubuntu-phablet dbus[1547]: apparmor="DENIED" operation="dbus_method_call" bus="session" path="/org/gnome/evolution/dataserver/SourceManager/Source_8" interface="org.gnome.evolution.dataserver.Source.Writable" member="Write" mask="send" name=":1.42" pid=17983 profile="com.ubuntu.calendar_calendar_0.4.237" peer_pid=2557 peer_profile="unconfined"
Jun 3 17:55:17 ubuntu-phablet dbus[1547]: apparmor="DENIED" operation="dbus_method_call" bus="session" path="/org/gnome/evolution/dataserver/SourceManager/Source_12" interface="org.gnome.evolution.dataserver.Source.Writable" member="Write" mask="send" name=":1.42" pid=17983 profile="com.ubuntu.calendar_calendar_0.4.237" peer_pid=2557 peer_profile="unconfined"

In /var/lib/apparmor/profiles/click_com.ubuntu.calendar_calendar_0.4.237 can you add:
dbus (receive, send)
     bus=session
     path=/org/gnome/evolution/dataserver/SourceManager/**,

then do:
$ sudo apparmor_parser -r /var/lib/apparmor/profiles/click_com.ubuntu.calendar_calendar_0.4.237

and try again?

> In /var/lib/apparmor/profiles/click_com.ubuntu.calendar_calendar_0.4.237 can
> you add:
> dbus (receive, send)
> bus=session
> path=/org/gnome/evolution/dataserver/SourceManager/**,
>
> then do:
> $ sudo apparmor_parser -r
> /var/lib/apparmor/profiles/click_com.ubuntu.calendar_calendar_0.4.237
>
> and try again?

Works.

I'll update apparmor-easyprof-ubuntu for this additional access. It will be in 1.2.4.

I've updated apparmor-easyprof-ubuntu for this additional access. It will be in 1.2.4, which I just uploaded.

Triggered a rebuild of this. Curious where this stands.

FAILED: Continuous integration, rev:237
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/545/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/485/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-trusty-amd64-ci/379/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/103/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/545/rebuild

FAILED: Continuous integration, rev:237
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/549/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/490/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-trusty-amd64-ci/383/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/107/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/549/rebuild

Needs to be rebased with trunk :-)

Text conflict in AgendaView.qml
Text conflict in EventBubble.qml
Text conflict in TimeLineBase.qml
Text conflict in calendar.qml
4 conflicts encountered.
bzr: ERROR: Conflicts from merge

Kunal, can you please merge from trunk and we'll get this landed. Thanks!

We are no longer blocked on apparmor I believe as 1.2.4 of apparmor-easyprof-ubuntu landed on the phone now.

#unblocked

> Kunal, can you please merge from trunk and we'll get this landed. Thanks!
>
> We are no longer blocked on apparmor I believe as 1.2.4 of apparmor-easyprof-
> ubuntu landed on the phone now.
>
> #unblocked

ok, Glad to know that we can now land this

PASSED: Continuous integration, rev:238
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/555/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/556
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/556/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/113

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/555/rebuild

I updated the code, but on device i still see some hangup and freeze after changing calendar filters. Not able to test on desktop. I am on release 87 on device.

Please test and see if you also faces same issue.

And also we need icon for calendars.

Works fine on desktop for me, but the UI is freezing, I did not find any problem in eds code.

PASSED: Continuous integration, rev:239
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/556/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/557
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/557/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/114

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/556/rebuild

> Works fine on desktop for me, but the UI is freezing, I did not find any
> problem in eds code.

Mine is trusty, so I guess i don't have required patches. I think I see the same freezing on phone. but I am not sure as well for what is causing the freeze.

I will check more.

I think this is probably down to renato running utopic, and you being on trusty. Can you try in the emulator - which will be utopic - Kunal?

This patch fix the problem: http://paste.ubuntu.com/7742247/

This patch will wait for some interval before reload all events, this optimize the app since you are saving all collections individually and you receive the collections changed event for each saved collection. With this patch the reload function will run only once.

I strongly suggest this patch for the calendar dialogs: http://paste.ubuntu.com/7742257/

The current implementation is confusing, the edit mode is a dead end since the toolbar disappear and I can not save the changes.

This patch will remove the edit mode and allow the user to change the color by clicking in the color square.

Is this now able to proceed with the patch from Renato?

> Is this now able to proceed with the patch from Renato?

Hi, my pc broke down. I was not able to test. hopefully I might recover my pc soon and will update about it.

Thanks for letting us know Kunal! Good luck with the PC!

FAILED: Continuous integration, rev:244
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/609/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/992
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/992/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/167

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/609/rebuild

I modified the code, now after changing the filter, calendar does not freeze.

But It looks like when I am trying to create UnionFilter with DetailFieldFilter and CollectionFilter,
CollectionFilter does not work.

3 + filter: UnionFilter {
524 + filters: [ collectionFilter /*,eventFilter ,eventOccurenceFilter*/ ]
525 + }

FAILED: Continuous integration, rev:245
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/610/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/993
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/993/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/168

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/610/rebuild

FAILED: Continuous integration, rev:246
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/613/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1031
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1031/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/171

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/613/rebuild

PASSED: Continuous integration, rev:247
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/615/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1052
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1052/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/173

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/615/rebuild

> I modified the code, now after changing the filter, calendar does not freeze.

What exactly do you want with these filters, they does not look correct for me:

Union filter will list events that matches with all filters and you are using a filter that conflict with each other.

        DetailFieldFilter{
            id: eventFilter
            detail: Detail.ItemType;
            field: Type.FieldType
            value: Type.Event
            matchFlags: Filter.MatchExactly
        }

        DetailFieldFilter{
            id: eventOccurenceFilter
            detail: Detail.ItemType;
            field: Type.FieldType
            value: Type.EventOccurrence
            matchFlags: Filter.MatchExactly
        }

A event can only be one type Type.EventOccurrence or Type.Event.

if you want to filter a event that is a EventOccurrence or a Event you should try Intersection filter.

Probably you will need a combination of Union and Intersection filters.

Hello,

It looks like I don't understand UnionFilter, what I want is all event that are either event or event occurrence and also belongs to collection which are selected by filter.

i understand now,

i tried to correct it here

https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/Filter-correction/+merge/227272

can you have a look ?