Code review comment for lp://staging/~pfalcon/linaro-android-build-tools/lava-update-urls

Revision history for this message
Данило Шеган (danilo) wrote :

Thanks for taking on this, Paul.

I have a single comment, in line 8, we don't want to replace all underscores, don't we?

  jenkins_job_name.replace('_', '/', 1)

should work better. Or do we really want to have job name 'danilo_blah_blah' transformed into '~danilo/blah/blah'?

Otherwise, this is good to land. We still have to make this script executed AFTER the build is published. Perhaps we can do that using another SSH script execution (maybe even by SSHing back to the jenkins master) and passing all the needed data as parameters. It would be better, of course, if we can somehow add a post-SSH step.

review: Approve

« Back to merge proposal