Merge lp://staging/~pfalcon/linaro-android-build-tools/lava-update-urls into lp://staging/linaro-android-build-tools

Proposed by Paul Sokolovsky
Status: Merged
Merged at revision: 386
Proposed branch: lp://staging/~pfalcon/linaro-android-build-tools/lava-update-urls
Merge into: lp://staging/linaro-android-build-tools
Diff against target: 32 lines (+7/-3)
1 file modified
build-scripts/post-build-lava.py (+7/-3)
To merge this branch: bzr merge lp://staging/~pfalcon/linaro-android-build-tools/lava-update-urls
Reviewer Review Type Date Requested Status
Данило Шеган (community) Approve
James Tunnicliffe Pending
Review via email: mp+86038@code.staging.launchpad.net

Description of the change

Update for LAVA integration.

To post a comment you must log in.
Revision history for this message
Данило Шеган (danilo) wrote :

Thanks for taking on this, Paul.

I have a single comment, in line 8, we don't want to replace all underscores, don't we?

  jenkins_job_name.replace('_', '/', 1)

should work better. Or do we really want to have job name 'danilo_blah_blah' transformed into '~danilo/blah/blah'?

Otherwise, this is good to land. We still have to make this script executed AFTER the build is published. Perhaps we can do that using another SSH script execution (maybe even by SSHing back to the jenkins master) and passing all the needed data as parameters. It would be better, of course, if we can somehow add a post-SSH step.

review: Approve
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

> Thanks for taking on this, Paul.
>
> I have a single comment, in line 8, we don't want to replace all underscores,
> don't we?
>
> jenkins_job_name.replace('_', '/', 1)
>
> should work better. Or do we really want to have job name 'danilo_blah_blah'
> transformed into '~danilo/blah/blah'?

The frontend doesn't allow jobs with '_' at all, but good catch - we for sure don't want path havoc in case manually created job sneaks in.

> Otherwise, this is good to land. We still have to make this script executed
> AFTER the build is published. Perhaps we can do that using another SSH script
> execution (maybe even by SSHing back to the jenkins master) and passing all
> the needed data as parameters. It would be better, of course, if we can
> somehow add a post-SSH step.

Ok, this is just minimal changes to revamp LAVA integration as it was. If we want to go further, let's do that as next steps. The problem, as I mentioned is parameter passing - there're some params in build config which are passed to LAVA, and previously there was no positive indication that publisher steps in Jenkins can access that (but worth re-checking).

387. By Paul Sokolovsky

Make frontend job name calculation for reliable.

Revision history for this message
Данило Шеган (danilo) wrote :

У пет, 16. 12 2011. у 13:34 +0000, Paul Sokolovsky пише:
>
> The frontend doesn't allow jobs with '_' at all, but good catch - we
> for sure don't want path havoc in case manually created job sneaks in.

We seem to have people who don't know enough about the current
architecture creating jobs as well (eg. me :). Better safe than sorry.

> Ok, this is just minimal changes to revamp LAVA integration as it was.
> If we want to go further, let's do that as next steps. The problem, as
> I mentioned is parameter passing - there're some params in build
> config which are passed to LAVA, and previously there was no positive
> indication that publisher steps in Jenkins can access that (but worth
> re-checking).

Sure, at the very least, I noticed that SSH plugin allows passing in a
bunch of jenkins variables (eg. those listed at
https://android-build.linaro.org/jenkins/env-vars.html) through eg. the
executed command.

Anyway, next step, let's get this landed at least.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches