Code review comment for lp://staging/~openerp-dev/openerp-web/6.1-opw-574907-msh

Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

* Missing translation marks (also please use double quotes for human-readable messages) on title and error message, also human-readable messages should use _.str.sprintf to allow correct full translation. Also fix capitalization, not all words need to start with capital letter in error messages
* Incorrect indentation and missing semicolons
* Do not do manual fetch of values when there already is `serializeArray` call, extract existing calls to `to_object()` into a variable (are two of it), this creates a map of {field: value} which can then be directly indexed
* Avoid jquery's utility functions when there is equivalent behavior in underscore.js, here `jQuery.inArray` should not be used, but should use `_.contains`

review: Needs Fixing

« Back to merge proposal