Odoo Web (MOVED TO GITHUB)

Merge lp://staging/~openerp-dev/openerp-web/6.1-opw-574907-msh into lp://staging/openerp-web/6.1

  1. 6.1-opw-574907-msh
  2. Merge into 6.1
Proposed by Mohammed Shekha(Open ERP)
Status: Merged
Approved by: Xavier (Open ERP)
Approved revision: 2347
Merged at revision: 2349
Proposed branch: lp://staging/~openerp-dev/openerp-web/6.1-opw-574907-msh
Merge into: lp://staging/openerp-web/6.1
Diff against target: 27 lines (+9/-2)
1 file modified
addons/web/static/src/js/chrome.js (+9/-2)
To merge this branch: bzr merge lp://staging/~openerp-dev/openerp-web/6.1-opw-574907-msh
Reviewer Review Type Date Requested Status
Xavier (Open ERP) (community) Approve
Mohammed Shekha(Open ERP) (community) Needs Resubmitting
Review via email: mp+106762@code.staging.launchpad.net

Description of the change

Hello,

Fixed the issue of database creation with the same name which is already exist, currently this is giving traceback instead of giving a user friendly message.

Thanks.

To post a comment you must log in.
lp://staging/~openerp-dev/openerp-web/6.1-opw-574907-msh updated
2331. By Xavier (Open ERP)

[FIX] issue with handling of list view priorities in dashboard

dashboard would select the default list view (id=false) instead of the asked/needed one, breaking the application of filters

2332. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

2333. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

2334. By Olivier Dony (Odoo)

[FIX] data_import: allow importing m2o via name_search() on top of their XML ID

We do default to exporting the XML ID, but there are
many cases where completely new data needs to be
imported and there is no XML ID available to do so.
In that case allowing name_search() to be used as in
6.0 is a life-saver. This patch simply makes the
m2o field itself visible during import, so users can
use it in their CSV file or manually select it.

Some trivial examples:
- you need to import 2000 new leads with their countries,
  obviously you can't guess that base.be should be used
  for country Belgium
- you need to update 2000 unassigned leads in the system
  and assign them to some of the salemen... but you don't
  have their XML IDs and even if you had, the match is
  quite hard to do.

2335. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

2336. By Christophe Simonis (OpenERP)

[FIX] web: correct jsonp behavior when len(payload) >= 2000

2337. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

2338. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

2339. By Xavier (Open ERP)

[FIX] handling of empty lines in CSV file being imported (ignore them)

2340. By Xavier (Open ERP)

[FIX] handling of get_selection in listview in case of non-selectable lists (e.g. editable o2ms?)

OPW 572764

2341. By Xavier (Open ERP)

[FIX] reloading of o2m forms in dialogs (popups) after clicking on a button

2342. By Xavier (Open ERP)

[FIX] handling of empty domains, context and view_id in action descriptors

* Some literal actions (not stored) provide an empty string for
  domains and contexts instead of (respectively) an empty array or an
  empty dict literal inside the string. Treat those case as nothing
  being provided.
* Likewise some literal actions provide nonsensical (but falsy, but
  not False) values for view_id (such as an empty list). Yield a
  ``False`` view_id for all falsy ``view_id`` received (``0`` should
  not be a valid view_id, so ``False`` works)

2343. By Xavier (Open ERP)

[IMP] performances when opening an m2o "search" without any filtering term

Don't prefilter via name_search if no data has been entered in the m2o
field, it's going to return all records (not paginated) so it's a
waste of time and resources

Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

* Missing translation marks (also please use double quotes for human-readable messages) on title and error message, also human-readable messages should use _.str.sprintf to allow correct full translation. Also fix capitalization, not all words need to start with capital letter in error messages
* Incorrect indentation and missing semicolons
* Do not do manual fetch of values when there already is `serializeArray` call, extract existing calls to `to_object()` into a variable (are two of it), this creates a map of {field: value} which can then be directly indexed
* Avoid jquery's utility functions when there is equivalent behavior in underscore.js, here `jQuery.inArray` should not be used, but should use `_.contains`

review: Needs Fixing
Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

(also $.inArray use is incorrect: it returns −1 if it does not find, not true/false)

lp://staging/~openerp-dev/openerp-web/6.1-opw-574907-msh updated
2344. By Xavier (Open ERP)

[FIX] incorrect handling of 'None of the following condition must match' advanced search combinator

Introduced during 'simple style fixes' (sic) of rev <email address hidden>

2345. By Olivier Dony (Odoo)

[MERGE] OPW 574895: fix incorrect matching of column headers when importing CSV files

- required fields may sometimes be provided by alternative columns,
  and all the alternatives are therefore not required (e.g. for
  a m2o the CSV can provide m2o or m2o/id columns)
- when fields share the same label, precedence when matching
  column headers should be given to the field with the exact
  same name, rather than just the first one encountered

2346. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

2347. By Mohammed Shekha(Open ERP)

[FIX]Refixed the issue of database creation which was giving traceback instead of message.

Revision history for this message
Mohammed Shekha(Open ERP) (msh-openerp) wrote :

Hello Xavier,

Thanks for the review.

I have changed the code accordingly as specified in previous comment.

Thanks.

Revision history for this message
Mohammed Shekha(Open ERP) (msh-openerp) :
review: Needs Resubmitting
Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

Excellent, thank you.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.