Ondrej Kubik

Code review comment for ~ondrak/+git/kernel-snaps-uc22:main

  1. Git
  2. lp:~ondrak/+git/kernel-snaps-uc22
  3. main
  4. Merge into main
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

broadcom drivers declare glob patterns of firmware they use, i.e.:

$ modinfo brcmfmac
...
firmware: brcm/brcmfmac*-pcie.*.txt
firmware: brcm/brcmfmac*-sdio.*.txt
...

I have a patch to fix that up, see https://lists.ubuntu.com/archives/kernel-team/2022-May/130085.html

You claim that your linux-firmware contains subdirectories under brcm/ but no sub-directories are supported by any brcm drivers that I can see.

What files do you have in sub-directories? Which drivers/kernels load them? And do those kernels declare those files with MODULE_FIRMWARE() stanza? To ensure that one can automatically discover and keep those?

review: Needs Information
Reply

« Back to merge proposal