Merge ~ondrak/+git/kernel-snaps-uc22:main into ~canonical-kernel-snaps/+git/kernel-snaps-uc22:main

Proposed by Ondrej Kubik
Status: Needs review
Proposed branch: ~ondrak/+git/kernel-snaps-uc22:main
Merge into: ~canonical-kernel-snaps/+git/kernel-snaps-uc22:main
Diff against target: 13 lines (+1/-1)
1 file modified
trim-firmware (+1/-1)
Reviewer Review Type Date Requested Status
Dimitri John Ledkov (community) Needs Information
Review via email: mp+421797@code.staging.launchpad.net

Commit message

Handle sub directories in firmware/brcm

To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

broadcom drivers declare glob patterns of firmware they use, i.e.:

$ modinfo brcmfmac
...
firmware: brcm/brcmfmac*-pcie.*.txt
firmware: brcm/brcmfmac*-sdio.*.txt
...

I have a patch to fix that up, see https://lists.ubuntu.com/archives/kernel-team/2022-May/130085.html

You claim that your linux-firmware contains subdirectories under brcm/ but no sub-directories are supported by any brcm drivers that I can see.

What files do you have in sub-directories? Which drivers/kernels load them? And do those kernels declare those files with MODULE_FIRMWARE() stanza? To ensure that one can automatically discover and keep those?

review: Needs Information

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches