Code review comment for lp://staging/~nik90/unav/move-about-page

> Am Montag, 4. April 2016 00:06:42 CEST schrieb Nekhelesh Ramananthan
> <email address hidden>:
> >> Hey,
> >>
> >
> > Thanks for the review.
> >
> >> 1. number of visible slots has to be reimplemented and set to 4
> >
> > Why? Previously we had number of slots set to 4 to hide the
> > settings and about button. But now that we have removed the
> > about button, there are only 4 buttons left. So I don't see why
> > we should explicitly set this. Right now, the header is
> > consistent in full-screen mode and normal mode.
> Well, it seems that desktop and phone (latest rc) behave different. Have
> never seen it on desktop, though.
> On phone default is 3.
> >
> >> 2. Order of elements has to be reorganized to fit fullscreen view.
> >>
> >
> > The order of elements match in both views (tested on desktop).
> > Do you see them different on the phone? Can you post screenshots
> > to showcase the issue.
> >
> You should get the original state if you just remove the about action and
> move settings to the top and keep the others, i hope
> Can not post a screenshot right now, sorry, tomorrow then or try marvin
> maybe that helps?
> Best joerg
>
>
> --
> Versandt, mit Dekko von meinem Ubuntu-Gerät

I found the issue and fixed it.