Merge lp://staging/~nik90/unav/move-about-page into lp://staging/unav

Hey,

1. number of visible slots has to be reimplemented and set to 4
2. Order of elements has to be reorganized to fit fullscreen view.

Best Joerg

> Hey,
>

Thanks for the review.

> 1. number of visible slots has to be reimplemented and set to 4

Why? Previously we had number of slots set to 4 to hide the settings and about button. But now that we have removed the about button, there are only 4 buttons left. So I don't see why we should explicitly set this. Right now, the header is consistent in full-screen mode and normal mode.

> 2. Order of elements has to be reorganized to fit fullscreen view.
>

The order of elements match in both views (tested on desktop). Do you see them different on the phone? Can you post screenshots to showcase the issue.

Bah ignore my previous comment once again...turns out it is an issue on the phone. You were right.

@Joerg, Fixed the issue in my latest commit. Nice catch!

Am Montag, 4. April 2016 00:06:42 CEST schrieb Nekhelesh Ramananthan
<email address hidden>:
>> Hey,
>>
>
> Thanks for the review.
>
>> 1. number of visible slots has to be reimplemented and set to 4
>
> Why? Previously we had number of slots set to 4 to hide the
> settings and about button. But now that we have removed the
> about button, there are only 4 buttons left. So I don't see why
> we should explicitly set this. Right now, the header is
> consistent in full-screen mode and normal mode.
Well, it seems that desktop and phone (latest rc) behave different. Have
never seen it on desktop, though.
On phone default is 3.
>
>> 2. Order of elements has to be reorganized to fit fullscreen view.
>>
>
> The order of elements match in both views (tested on desktop).
> Do you see them different on the phone? Can you post screenshots
> to showcase the issue.
>
You should get the original state if you just remove the about action and
move settings to the top and keep the others, i hope
Can not post a screenshot right now, sorry, tomorrow then or try marvin
maybe that helps?
 Best joerg

--
Versandt, mit Dekko von meinem Ubuntu-Gerät

> Am Montag, 4. April 2016 00:06:42 CEST schrieb Nekhelesh Ramananthan
> <email address hidden>:
> >> Hey,
> >>
> >
> > Thanks for the review.
> >
> >> 1. number of visible slots has to be reimplemented and set to 4
> >
> > Why? Previously we had number of slots set to 4 to hide the
> > settings and about button. But now that we have removed the
> > about button, there are only 4 buttons left. So I don't see why
> > we should explicitly set this. Right now, the header is
> > consistent in full-screen mode and normal mode.
> Well, it seems that desktop and phone (latest rc) behave different. Have
> never seen it on desktop, though.
> On phone default is 3.
> >
> >> 2. Order of elements has to be reorganized to fit fullscreen view.
> >>
> >
> > The order of elements match in both views (tested on desktop).
> > Do you see them different on the phone? Can you post screenshots
> > to showcase the issue.
> >
> You should get the original state if you just remove the about action and
> move settings to the top and keep the others, i hope
> Can not post a screenshot right now, sorry, tomorrow then or try marvin
> maybe that helps?
> Best joerg
>
>
> --
> Versandt, mit Dekko von meinem Ubuntu-Gerät

I found the issue and fixed it.

I see a grey line with header = fullscreen.
http://s23.postimg.org/cpirpgwx7/Screenshot_from_2016_04_04_19_20_48.png
Is possible to remove it? Thanks in advance!

Only happens on desktop.
Thanks a lot Nekhelesh :))

Hey,

i do not see the divider on phone.
Strange, as this divider should be associated to the header and be gone on header.visible=false.
So, at least for the phone i approve this change.

Looking forward to the "Details" page/popup!
Maybe we can abandon the big buttons then and keep it an abstractbutton
in the action popover.

Am 2016-04-04 um 19:27 schrieb costales:
> Review: Approve
>
> Only happens on desktop.
> Thanks a lot Nekhelesh :))
>