Code review comment for lp://staging/~nik90/unav/move-about-page
Revision history for this message
| Nekhelesh Ramananthan (nik90) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
2eb648a
demo site
(Get the code!)
> Hey,
>
Thanks for the review.
> 1. number of visible slots has to be reimplemented and set to 4
Why? Previously we had number of slots set to 4 to hide the settings and about button. But now that we have removed the about button, there are only 4 buttons left. So I don't see why we should explicitly set this. Right now, the header is consistent in full-screen mode and normal mode.
> 2. Order of elements has to be reorganized to fit fullscreen view.
>
The order of elements match in both views (tested on desktop). Do you see them different on the phone? Can you post screenshots to showcase the issue.