Code review comment for ~netplan-developers/netplan/+git/netplan-lp:cyphermox/routes

Revision history for this message
Martin Pitt (pitti) wrote :

The general structure looks good to me, I have a bunch of inline comments.

This is missing the NM implementation and extending the integration test case to cover this.

review: Needs Fixing

« Back to merge proposal