Merge ~netplan-developers/netplan/+git/netplan-lp:cyphermox/routes into ~netplan-developers/netplan/+git/netplan-lp:master
Proposed by
Mathieu Trudel-Lapierre
| Status: | Merged |
|---|---|
| Approved by: | Mathieu Trudel-Lapierre |
| Approved revision: | 88e5179fcd84a69e9b65c3f4f8a550f7d82eb555 |
| Merged at revision: | 8498f9c72f33c26ce2e8b42b45d71b2a89594907 |
| Proposed branch: | ~netplan-developers/netplan/+git/netplan-lp:cyphermox/routes |
| Merge into: | ~netplan-developers/netplan/+git/netplan-lp:master |
| Diff against target: |
814 lines (+643/-0) 6 files modified
src/networkd.c (+9/-0) src/nm.c (+25/-0) src/parse.c (+124/-0) src/parse.h (+13/-0) tests/generate.py (+399/-0) tests/integration.py (+73/-0) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mathieu Trudel-Lapierre (community) | Approve | ||
| Martin Pitt (community) | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
Add support for defining routes.
To post a comment you must log in.
Revision history for this message
| Martin Pitt (pitti) | # |
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The general structure looks good to me, I have a bunch of inline comments.
This is missing the NM implementation and extending the integration test case to cover this.