Code review comment for lp://staging/~nataliabidart/ubuntu-sso-client/assert-is-gone
Revision history for this message
| Natalia Bidart (nataliabidart) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
5466644
demo site
(Get the code!)
> On Mon, Aug 30, 2010 at 08:19:37PM -0000, Alejandro J. Cura wrote:
> > Review: Needs Fixing
> > I really like that the bug mentioned is being resolved, thanks.
> >
> > I don't like that old code is being turned off in this same branch and
> without an explicit bug number. By that I mean the commented lines in bin
> /ubuntu-sso-login.
>
> that's being reverted. I think nessita forgot to push it, because I
> pointed it out before approving (and she fixed it). Don't mark the
> branch approved until that's fixed :)
Sorry! I've pushed a while ago but to the wrong location. Pushed correctly now.