Ubuntu Single Sign On Client

Merge lp://staging/~nataliabidart/ubuntu-sso-client/assert-is-gone into lp://staging/ubuntu-sso-client

assert-is-gone
Merge into trunk

Proposed by Natalia Bidart on 2010-08-30

Status:

Merged

Approved by:

Alejandro J. Cura on 2010-08-31

Approved revision:

608

Merged at revision:

606

Proposed branch:

lp://staging/~nataliabidart/ubuntu-sso-client/assert-is-gone

Merge into:

lp://staging/ubuntu-sso-client

Diff against target:

90 lines (+17/-20)

3 files modified

ubuntu_sso/gui.py (+13/-16)
ubuntu_sso/logger.py (+3/-3)
ubuntu_sso/tests/test_gui.py (+1/-1)

To merge this branch:

bzr merge lp://staging/~nataliabidart/ubuntu-sso-client/assert-is-gone

High

Fix Released

Link a bug report

Reviewer	Date Requested	Status
Alejandro J. Cura (community)		Approve on 2010-08-31
John Lenton (community)	2010-08-30	Approve on 2010-08-30
Review via email: mp+34107@code.staging.launchpad.net

Commit message

* Made DBus signal connection more robust (LP: #624127).

Description of the change

Made DBus signal connection more robust (LP: #624127).

To test you cna use the script attached in the linked bug, and see how without the branch the "assert actual is None" is failing if executed more than once, and with this branch we get WARNING messages.

lp://staging/~nataliabidart/ubuntu-sso-client/assert-is-gone updated on 2010-08-30

607. By Natalia Bidart on 2010-08-30: Restoring code from trunk.

Revision history for this message

John Lenton (chipaca) on 2010-08-30:

review: Approve

Revision history for this message

Alejandro J. Cura (alecu) wrote on 2010-08-30:

I really like that the bug mentioned is being resolved, thanks.

I don't like that old code is being turned off in this same branch and without an explicit bug number. By that I mean the commented lines in bin/ubuntu-sso-login.

review: Needs Fixing

Revision history for this message

John Lenton (chipaca) wrote on 2010-08-30:

On Mon, Aug 30, 2010 at 08:19:37PM -0000, Alejandro J. Cura wrote:
> Review: Needs Fixing
> I really like that the bug mentioned is being resolved, thanks.
>
> I don't like that old code is being turned off in this same branch and without an explicit bug number. By that I mean the commented lines in bin/ubuntu-sso-login.

that's being reverted. I think nessita forgot to push it, because I
pointed it out before approving (and she fixed it). Don't mark the
branch approved until that's fixed :)

Revision history for this message

Natalia Bidart (nataliabidart) wrote on 2010-08-30:

> On Mon, Aug 30, 2010 at 08:19:37PM -0000, Alejandro J. Cura wrote:
> > Review: Needs Fixing
> > I really like that the bug mentioned is being resolved, thanks.
> >
> > I don't like that old code is being turned off in this same branch and
> without an explicit bug number. By that I mean the commented lines in bin
> /ubuntu-sso-login.
>
> that's being reverted. I think nessita forgot to push it, because I
> pointed it out before approving (and she fixed it). Don't mark the
> branch approved until that's fixed :)

Sorry! I've pushed a while ago but to the wrong location. Pushed correctly now.

lp://staging/~nataliabidart/ubuntu-sso-client/assert-is-gone updated on 2010-08-30