Ubuntu Single Sign On Client

Code review comment for lp://staging/~nataliabidart/ubuntu-sso-client/assert-is-gone

  1. assert-is-gone
  2. Merge into trunk
Revision history for this message
John Lenton (chipaca) wrote :

On Mon, Aug 30, 2010 at 08:19:37PM -0000, Alejandro J. Cura wrote:
> Review: Needs Fixing
> I really like that the bug mentioned is being resolved, thanks.
>
> I don't like that old code is being turned off in this same branch and without an explicit bug number. By that I mean the commented lines in bin/ubuntu-sso-login.

that's being reverted. I think nessita forgot to push it, because I
pointed it out before approving (and she fixed it). Don't mark the
branch approved until that's fixed :)

« Back to merge proposal