Code review comment for lp://staging/~mzanetti/reminders-app/notes-headers

Revision history for this message
David Planella (dpm) wrote :

Just one thing I've noticed at a quick glance before testing it on a device:

61 + return QStringLiteral("Today");

This string (and all of those inside that same function) needs to be internationalized, either using the i18n plugin from the SDK (I still couldn't figure out whether it can be used from C++ or only from QML) or with plain gettext (which should work in any case).

review: Needs Fixing

« Back to merge proposal