Merge lp://staging/~mzanetti/reminders-app/notes-headers into lp://staging/~notes-app-dev/reminders-app/new-design

Proposed by Michael Zanetti
Status: Superseded
Proposed branch: lp://staging/~mzanetti/reminders-app/notes-headers
Merge into: lp://staging/~notes-app-dev/reminders-app/new-design
Diff against target: 229 lines (+72/-9)
8 files modified
debian/control (+1/-0)
src/app/qml/ui/NotesPage.qml (+18/-0)
src/plugin/Evernote/note.cpp (+28/-6)
src/plugin/Evernote/note.h (+2/-0)
src/plugin/Evernote/notes.cpp (+16/-2)
src/plugin/Evernote/notes.h (+2/-0)
src/plugin/Evernote/notesstore.cpp (+3/-0)
src/plugin/Evernote/notesstore.h (+2/-1)
To merge this branch: bzr merge lp://staging/~mzanetti/reminders-app/notes-headers
Reviewer Review Type Date Requested Status
David Planella Needs Fixing
Review via email: mp+218328@code.staging.launchpad.net

Commit message

added sectionheaders to NotesList as per new design

To post a comment you must log in.
97. By Michael Zanetti

merge

Revision history for this message
David Planella (dpm) wrote :

Just one thing I've noticed at a quick glance before testing it on a device:

61 + return QStringLiteral("Today");

This string (and all of those inside that same function) needs to be internationalized, either using the i18n plugin from the SDK (I still couldn't figure out whether it can be used from C++ or only from QML) or with plain gettext (which should work in any case).

review: Needs Fixing
Revision history for this message
David Planella (dpm) wrote :

107 +// sort(0, Qt::DescendingOrder);

Why has the sorting been commented out?

Revision history for this message
Michael Zanetti (mzanetti) wrote :

> 107 +// sort(0, Qt::DescendingOrder);
>
> Why has the sorting been commented out?

good catch :D I hoped to sneak them in with noone noticing :D

No, this disables sorting, which works around *the* bug. I thought as long as this won't end up in trunk (and as long as I don't have the patch on my desktop-qt) I'd just work around it. Will enable them back when merging to trunk or when the qt patch hits my and Ricardo's desktops, whichever comes first.

98. By Michael Zanetti

make it translatable

Revision history for this message
David Planella (dpm) wrote :

Looking at my list of notes, they all now get put under the "Last week" section, when they're clearly older than that.

See the screenshot at http://i.imgur.com/NDDRjyv.png

review: Needs Fixing
Revision history for this message
Michael Zanetti (mzanetti) wrote :

> Just one thing I've noticed at a quick glance before testing it on a device:
>
> 61 + return QStringLiteral("Today");
>
> This string (and all of those inside that same function) needs to be
> internationalized, either using the i18n plugin from the SDK (I still couldn't
> figure out whether it can be used from C++ or only from QML) or with plain
> gettext (which should work in any case).

fixed

99. By Michael Zanetti

d'oh!

Revision history for this message
David Planella (dpm) wrote :

Michael, I think even before the new design lands, this is a really cool improvement already on the notes list. As I'm guessing the new design might not be ready by the end of the week when we'd like to talk to the Evernote guys, do you think it might be worth splitting this into two branches, so that we can land this already, independently of the new design (i.e. landing this without the coloured note titles)?

Unmerged revisions

99. By Michael Zanetti

d'oh!

98. By Michael Zanetti

make it translatable

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches