Code review comment for lp://staging/~mvo/software-center/click_url

Revision history for this message
Michael Vogt (mvo) wrote :

On Mon, Jul 09, 2012 at 10:39:20PM -0000, Gary Lasker wrote:
> Review: Approve
>
> Hi Michael, this code looks good and the test case seems good. Were you by chance able to test this in the "real world" using a banner with a click_url value from the agent? In any case, this is straightforward and seems fine and so I will set this to approved and merge it.

Thanks for the review. I don't know of a easy way. One is to see if
the staging server for software-center-agent supports it and add one
there, the other one would be to make the default exhibit have a
click_url just for testing.

Cheers,
 Michael

« Back to merge proposal