Ubuntu Software Center

Merge lp://staging/~mvo/software-center/click_url into lp://staging/software-center/5.2

click_url
Merge into 5.2

Proposed by Michael Vogt on 2012-07-02

Status:	Merged
Merged at revision:	3059
Proposed branch:	lp://staging/~mvo/software-center/click_url
Merge into:	lp://staging/software-center/5.2
Diff against target:	110 lines (+44/-7) 4 files modified softwarecenter/backend/scagent.py (+3/-0) softwarecenter/ui/gtk3/views/catview_gtk.py (+11/-4) softwarecenter/ui/gtk3/widgets/exhibits.py (+1/-2) test/gtk3/test_catview.py (+29/-1)
To merge this branch:	bzr merge lp://staging/~mvo/software-center/click_url
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Gary Lasker (community)		2012-07-02	Approve on 2012-07-09
Review via email: mp+113079@code.staging.launchpad.net

Description of the change

This small branch adds support for a "click_url" from the exhibits banner to support banners for things like the humble-bundle where we don't have packages but URLs.

Revision history for this message

Gary Lasker (gary-lasker) wrote on 2012-07-09:

Hi Michael, this code looks good and the test case seems good. Were you by chance able to test this in the "real world" using a banner with a click_url value from the agent? In any case, this is straightforward and seems fine and so I will set this to approved and merge it.

Many thanks!

review: Approve

Revision history for this message

Michael Vogt (mvo) wrote on 2012-07-10:

On Mon, Jul 09, 2012 at 10:39:20PM -0000, Gary Lasker wrote:
> Review: Approve
>
> Hi Michael, this code looks good and the test case seems good. Were you by chance able to test this in the "real world" using a banner with a click_url value from the agent? In any case, this is straightforward and seems fine and so I will set this to approved and merge it.

Thanks for the review. I don't know of a easy way. One is to see if
the staging server for software-center-agent supports it and add one
there, the other one would be to make the default exhibit have a
click_url just for testing.

Cheers,
Michael