Code review comment for lp://staging/~mterry/update-manager/dialogs

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

The branch looks good, nice work :)

+ print("Hello!")

+ print("Hello2!", self.window_main)

Aren't they debug info that you left over?

319 + except:
320 + pass
-> you don't want to add some logging info here?

Couldn't really get all the insight of the changes TBH, we should have a class diagram :)

review: Approve

« Back to merge proposal