Software Updater

Merge lp://staging/~mterry/update-manager/dialogs into lp://staging/update-manager

dialogs
Merge into main

Proposed by Michael Terry on 2012-06-18

Status:	Merged
Approved by:	Didier Roche-Tolomelli on 2012-06-26
Approved revision:	2452
Merged at revision:	2507
Proposed branch:	lp://staging/~mterry/update-manager/dialogs
Merge into:	lp://staging/update-manager
Prerequisite:	lp://staging/~mterry/update-manager/single-window
Diff against target:	2631 lines (+879/-1244) 18 files modified UpdateManager/Core/MetaRelease.py (+6/-2) UpdateManager/Core/utils.py (+18/-5) UpdateManager/Dialogs.py (+237/-0) UpdateManager/DistUpgradeFetcher.py (+12/-15) UpdateManager/GtkProgress.py (+10/-131) UpdateManager/InstallProgress.py (+1/-9) UpdateManager/MetaReleaseGObject.py (+10/-8) UpdateManager/UpdateManager.py (+146/-10) UpdateManager/UpdateProgress.py (+0/-7) UpdateManager/UpdatesAvailable.py (+44/-306) UpdateManager/backend/InstallBackendAptdaemon.py (+4/-5) check-new-release-gtk (+9/-5) data/gtkbuilder/AcquireProgress.ui (+161/-0) data/gtkbuilder/Dialog.ui (+123/-0) data/gtkbuilder/ReleaseNotes.ui (+88/-0) data/gtkbuilder/UpdateManager.ui (+3/-738) tests/interactive_fetch_release_upgrader.py (+5/-2) tests/test_end_of_life.py (+2/-1)
To merge this branch:	bzr merge lp://staging/~mterry/update-manager/dialogs
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Didier Roche-Tolomelli		Approve on 2012-06-26
Michael Vogt	2012-06-18	Pending
Review via email: mp+110900@code.staging.launchpad.net

This proposal supersedes a proposal from 2012-06-18.

Description of the change

This branch implements a lot of the special purpose dialogs in the Software Updates spec.
https://wiki.ubuntu.com/SoftwareUpdates

Specifically, the new release, unsupported release, errors, and no updates dialogs.

(whoops, resubmitted to include the prereq branch)

Revision history for this message

Didier Roche-Tolomelli (didrocks) wrote on 2012-06-26:

The branch looks good, nice work :)

+ print("Hello!")

+ print("Hello2!", self.window_main)

Aren't they debug info that you left over?

319 + except:
320 + pass
-> you don't want to add some logging info here?

Couldn't really get all the insight of the changes TBH, we should have a class diagram :)

review: Approve

Revision history for this message

Michael Terry (mterry) wrote on 2012-06-27:

I dropped the debugging prints that squeezed into my branch. About the except/pass, that was just copy/pasted from elsewhere in the code. So I didn't feel the need to change it.