Code review comment for lp://staging/~mterry/unity8/unlock-sim-after-wizard

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

> > Why is that needed?
>
> Because the loader's active property was emitting a changed signal during
> object creation as an alias. Having it cached as a property made it only emit
> a changed signal when it actually did change.
>
> I figured it was some quirk of qml that I didn't understand. But it seemed
> like a harmless enough change.

That's really odd. Certainly deserves a comment in the code. Specially if your code will misbehave in case it's changed to an alias back again.

« Back to merge proposal