lp://staging/~mterry/unity8/unlock-sim-after-wizard
- Get this branch:
- bzr branch lp://staging/~mterry/unity8/unlock-sim-after-wizard
Branch merges
- MichaĆ Sawicz: Approve (functional)
- Daniel d'Andrada (community): Approve (code)
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
-
Diff: 113 lines (+34/-6)4 files modifiedqml/Greeter/Greeter.qml (+0/-5)
qml/Shell.qml (+11/-0)
qml/Wizard/Wizard.qml (+6/-1)
tests/qmltests/tst_Shell.qml (+17/-0)
Related bugs
Related blueprints
Branch information
Recent revisions
- 1639. By Michael Terry
-
Add some comments on why we cache the 'active' bool instead of using an alias
- 1633. By Albert Astals Cid
-
Do not declare the hostname property twice
Approved by: Michael Terry, Andrea Cimitan - 1632. By Michael Terry
-
Wait for libqofono to finish initializing before we decide whether to skip the wizard's SIM page or not.
libqofono became asynchronous on its last upload (about a month ago), which the wizard was not prepared for. We didn't notice because our mocks continued their synchronous behavior, and in manual testing, it's easy to miss (you'd have to not have a SIM in, and then notice that you *didn't* get a screen).
I've updated our mock to be asynchronous (to get the desired signal timing behavior, I switched one of our mock classes to C++ from qml).
And I've added support for artificially extending the delays in the async flow. This lets us test those delays specifically. And obviously, I added a couple tests to do so. Fixes: #1423565
Approved by: Albert Astals Cid - 1630. By Michael Terry
-
Move the gschema file to data/ and install it via cmake, not dpkg.
Approved by: Albert Astals Cid
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp://staging/unity8