Code review comment for lp://staging/~mterry/lightdm/qt-get

Revision history for this message
David Edmundson (david.edmundson) wrote :

In "normal" C++ code one would do model->index(rowNumber,0).data(Qt::DisplayRole) that's quite common. Quite often one passes round QPersistantModelIndexes anyway so you can just call data() on that.

From a C++ QWidget perspective this would be really wrong and pointless, however I do see why you want to do it to work round QML's limitations. I hate making bad Qt libraries with duplication for the sake of QML, which is what this comes down to.

If you don't have a itemAt() method you can still call pathView.children[index].property.
What I'll do is check with some other Qt devs and get their opinion and report back.

« Back to merge proposal