Merge lp://staging/~mterry/lightdm/qt-get into lp://staging/lightdm
Proposed by
Michael Terry
Status: | Rejected |
---|---|
Rejected by: | Michael Terry |
Proposed branch: | lp://staging/~mterry/lightdm/qt-get |
Merge into: | lp://staging/lightdm |
Diff against target: |
70 lines (+27/-0) 4 files modified
liblightdm-qt/QLightDM/sessionsmodel.h (+1/-0) liblightdm-qt/QLightDM/usersmodel.h (+1/-0) liblightdm-qt/sessionsmodel.cpp (+13/-0) liblightdm-qt/usersmodel.cpp (+12/-0) |
To merge this branch: | bzr merge lp://staging/~mterry/lightdm/qt-get |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Ancell | Abstain | ||
PS Jenkins bot | continuous-integration | Approve | |
David Edmundson | Disapprove | ||
Review via email: mp+149119@code.staging.launchpad.net |
Commit message
Add get() methods to the Qt models, to emulate what ListModel does in Qml
Description of the change
Add get() methods to the two Qt models. This makes it possible to get data from arbitrary rows of the model (otherwise, Qml only exposes the currently selected row).
To post a comment you must log in.
Unmerged revisions
- 1597. By Michael Terry
-
Add get() methods to the Qt models, to emulate what ListModel does in Qml
That's not true, use itemAt() in your repeater in QML, then you have access to all the properties in your delegate (and thus model)
Show me your QML and I can take a look if you like.