Code review comment for lp://staging/~morphis/network-manager/fix-lp1560793

Revision history for this message
Tony Espy (awe) wrote :

Note, I will add that although the proposed fix makes sense, as there is a new race condition that was introduced by the last upload, the odds of hitting this are low the disable WiFi event needs to happen after a scan has been requested, but before it's results are available.

I tested over 60 iterations on krillin ( rc-proposed / 290 ) and arale ( rc-proposed / 238 ) and never hit this bug. Note, I also made sure to have the Nearby scope active, as this increases the frequency of WiFi scans to every 10-12s.

« Back to merge proposal