Merge lp://staging/~morphis/network-manager/fix-lp1560793 into lp://staging/~phablet-team/network-manager/vivid-phone-overlay

Proposed by Simon Fels
Status: Merged
Approved by: Tony Espy
Approved revision: 975
Merged at revision: 973
Proposed branch: lp://staging/~morphis/network-manager/fix-lp1560793
Merge into: lp://staging/~phablet-team/network-manager/vivid-phone-overlay
Diff against target: 104 lines (+84/-0)
3 files modified
debian/changelog (+11/-0)
debian/patches/clear-requested-scan-when-supplicant-goes-down.patch (+72/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp://staging/~morphis/network-manager/fix-lp1560793
Reviewer Review Type Date Requested Status
Tony Espy Approve
Review via email:

Commit message

Clear flag which indicates if a new scan is requested or not when a
WiFi interface is removed from supplicant to prevent us from not
issuing a scan again when we the interface becomes available again.

To post a comment you must log in.
975. By Simon Fels

Add missing patch

Revision history for this message
Tony Espy (awe) :
review: Approve
Revision history for this message
Tony Espy (awe) wrote :

Note, I will add that although the proposed fix makes sense, as there is a new race condition that was introduced by the last upload, the odds of hitting this are low the disable WiFi event needs to happen after a scan has been requested, but before it's results are available.

I tested over 60 iterations on krillin ( rc-proposed / 290 ) and arale ( rc-proposed / 238 ) and never hit this bug. Note, I also made sure to have the Nearby scope active, as this increases the frequency of WiFi scans to every 10-12s.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.


People subscribed via source and target branches