Code review comment for lp://staging/~michael.nelson/software-center/add-initiate-purchase

On Mon, Dec 17, 2012 at 9:35 AM, Michael Vogt <email address hidden>wrote:

> Review: Approve
>
> Looks good to me.
>
> My only minor concern is that order-id and subscription-id being identical
> is a bit confusing, maybe we should have a the subscription id encoded in
> the order-id much like you suggested? Like "sca_subscriptionid:%s" %
> subscription['id'] or something? just to make it obvious that they are not
> the same (or if they are the same we could make this obvious too as the
> subscription-id is the bit that will be used by
> aptdaemon/software-center-purchase-helper to actually retrieve the app.
>

Thanks mvo - I've pushed that change with r26, the relevant test change
r887 on the sca branch at:

https://code.launchpad.net/~michael.nelson/software-center-agent/further-tests-scaclient/+merge/139717

> --
>
> https://code.launchpad.net/~michael.nelson/software-center/add-initiate-purchase/+merge/137831
> Your team Canonical Consumer Applications Hackers is subscribed to branch
> lp:~canonical-ca-hackers/software-center/scaclient.
>

--
Michael Nelson - http://micknelson.wordpress.com/