Ubuntu Software Center

NOTES:
* For the purchase_with_default_method call, i'm assuming that the oauth token used to authenticate will itself be the fresh token (as the client can use the SSO api to refresh a token). But if the decision goes otherwise, I can update that also.
* Also, currently the subscription id is being returned as 'order_id', but based on the gdoc, perhaps 'sca_%' % subscription['id'] is intended?

To test the scaclient, branch the further-tests-scaclient branch above, link this current scaclient branch in the right spot and run the tests:
$ bzr branch lp:~michael.nelson/software-center-agent/further-tests-scaclient
$ bzr branch lp:~michael.nelson/software-center/add-initiate-purchase
$ cd further-tests-scaclient && fab bootstrap
$ cd django_project && rm scaclient.py && ln -s ../../add-initiate-purchase/scaclient.py
$ cd .. && fab test:softwarecenteragent.SCAClientSubscriptionsTestCase

Revision history for this message

Michael Vogt (mvo) wrote on 2012-12-17:

Looks good to me.

My only minor concern is that order-id and subscription-id being identical is a bit confusing, maybe we should have a the subscription id encoded in the order-id much like you suggested? Like "sca_subscriptionid:%s" % subscription['id'] or something? just to make it obvious that they are not the same (or if they are the same we could make this obvious too as the subscription-id is the bit that will be used by aptdaemon/software-center-purchase-helper to actually retrieve the app.

review: Approve

lp://staging/~michael.nelson/software-center/add-initiate-purchase updated on 2012-12-17

26. By Michael Nelson on 2012-12-17: orde_id should be 'scasubscription_id:%s' % subscription['id'].

Revision history for this message

Michael Nelson (michael.nelson) wrote on 2012-12-17:

On Mon, Dec 17, 2012 at 9:35 AM, Michael Vogt <email address hidden>wrote:

> Review: Approve
>
> Looks good to me.
>
> My only minor concern is that order-id and subscription-id being identical
> is a bit confusing, maybe we should have a the subscription id encoded in
> the order-id much like you suggested? Like "sca_subscriptionid:%s" %
> subscription['id'] or something? just to make it obvious that they are not
> the same (or if they are the same we could make this obvious too as the
> subscription-id is the bit that will be used by
> aptdaemon/software-center-purchase-helper to actually retrieve the app.
>