Merge lp://staging/~mhr3/unity/pass-extra-hints-for-perform-action into lp://staging/unity
Proposed by
Michal Hruby
Status: | Merged |
---|---|
Approved by: | Paweł Stołowski |
Approved revision: | no longer in the source branch. |
Merged at revision: | 2661 |
Proposed branch: | lp://staging/~mhr3/unity/pass-extra-hints-for-perform-action |
Merge into: | lp://staging/unity |
Diff against target: |
183 lines (+85/-12) 5 files modified
UnityCore/Lens.cpp (+37/-8) UnityCore/Lens.h (+2/-1) UnityCore/Preview.cpp (+2/-2) UnityCore/Preview.h (+3/-1) tests/test_lens.cpp (+41/-0) |
To merge this branch: | bzr merge lp://staging/~mhr3/unity/pass-extra-hints-for-perform-action |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Paweł Stołowski (community) | Approve | ||
Nick Dedekind (community) | Approve | ||
jenkins | continuous-integration | Pending | |
Review via email: mp+122547@code.staging.launchpad.net |
Commit message
Make sure we can pass extra hints when activating preview actions
Description of the change
Make sure we can pass extra hints when activating preview actions. This also adds compability with latest changes in libunity.
Added tests for the issue.
The related libunity branch is @ https:/
To post a comment you must log in.
LGTM
Only comment is that it would be better if you could use the Hints typedef in dash::Preview: :PerformAction.
161 + void PerformAction( std::string const& id, std::string, glib::Variant> const& hints = std::string, glib::Variant>()) const;
162 + std::map<
163 + std::map<