Code review comment for lp://staging/~mhr3/unity/pass-extra-hints-for-perform-action

Revision history for this message
Michal Hruby (mhr3) wrote :

> LGTM
>
> Only comment is that it would be better if you could use the Hints typedef in
> dash::Preview::PerformAction.
>

Wanted to, but it's defined in Lens.h, which includes Previews, so there'd be a circular dependency... :(

« Back to merge proposal