Merge lp://staging/~mhall119/ubuntu-community-accomplishments/approved-loco-team into lp://staging/ubuntu-community-accomplishments
Proposed by
Michael Hall
Status: | Rejected |
---|---|
Rejected by: | Jono Bacon |
Proposed branch: | lp://staging/~mhall119/ubuntu-community-accomplishments/approved-loco-team |
Merge into: | lp://staging/ubuntu-community-accomplishments |
Diff against target: |
96 lines (+59/-1) 5 files modified
CATEGORIES (+1/-0) accomplishments/ubuntu-community/en/advocacy/member-approved-loco-team.accomplishment (+17/-0) accomplishments/ubuntu-community/en/advocacy/member-loco-team.accomplishment (+1/-1) scripts/ubuntu-community/advocacy/member-approved-loco-team.py (+35/-0) tests/ubuntu-community/advocacy/member-approved-loco-team (+5/-0) |
To merge this branch: | bzr merge lp://staging/~mhall119/ubuntu-community-accomplishments/approved-loco-team |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jono Bacon | Disapprove | ||
Rafał Cieślak | Needs Information | ||
Review via email:
|
Commit message
Add accomplishment for being a member of an approved loco team
Description of the change
Add accomplishment for being a member of an approved loco team
** NEEDS SUMMARY AND STEPS ADDED **
To post a comment you must log in.
Unmerged revisions
- 146. By Michael Hall
-
Merge from trunk
- 145. By Michael Hall
-
Add LoCo Teams:Membership to the CATEGORIES file
- 144. By Michael Hall
-
Add sub-category for LoCo Teams:Membership
- 143. By Michael Hall
-
Add accomplishment for being a member of an approved loco team
Thanks for the MP, Michael!
There are two problems I see about this submission:
* Fields 'summary' and 'steps' are left empty. I doubt this is intentional, as then there is almost no information about the accomplishment, so I guess you simply forgot to fill them in. Could you please fix that?
* I wonder if we really want separate accomplishments for 'Be a member of a loco team' and 'Be a member of an approved loco team'. There are mainly two cases: a) the user will get them both at once, if his team is already registered, and b) the user will get just one of them, if his team is not registered. In both there is only one element for rewarding him for his activity, that is joining a LoCo. The fact of whether his loco is registered or not is not much an average can do about when he joins the team. This said, the only thing worth rewarding in that matter would be 'Get your LoCo to be approved', but that's a different story. I have requested a review directly from Jono, maybe he can help recognize if such accomplishment makes sense.