Code review comment for lp://staging/~mhall119/ubuntu-community-accomplishments/approved-loco-team

Revision history for this message
Rafał Cieślak (rafalcieslak256) wrote :

Thanks for the MP, Michael!
There are two problems I see about this submission:
 * Fields 'summary' and 'steps' are left empty. I doubt this is intentional, as then there is almost no information about the accomplishment, so I guess you simply forgot to fill them in. Could you please fix that?
 * I wonder if we really want separate accomplishments for 'Be a member of a loco team' and 'Be a member of an approved loco team'. There are mainly two cases: a) the user will get them both at once, if his team is already registered, and b) the user will get just one of them, if his team is not registered. In both there is only one element for rewarding him for his activity, that is joining a LoCo. The fact of whether his loco is registered or not is not much an average can do about when he joins the team. This said, the only thing worth rewarding in that matter would be 'Get your LoCo to be approved', but that's a different story. I have requested a review directly from Jono, maybe he can help recognize if such accomplishment makes sense.

review: Needs Information

« Back to merge proposal