Code review comment for lp://staging/~mfrey/powerd/filter-proximity

Revision history for this message
Ricardo Salveti (rsalveti) wrote :

While testing I noticed that if I start a call with something covering up the proximity sensor, the screen will never be off, which might be a side effect of this change.

I wonder if it might be better to work instead fixing the sensor for this hardware specifically, for it to always give a valid value when doing the first read. I know bug #1378043 is actually a side effect of doing the screen handling on powerd and not as part of the phone stack (if the screen gets off before the call starts, the phone will lock itself).

review: Needs Fixing

« Back to merge proposal