powerd

Merge lp://staging/~mfrey/powerd/filter-proximity into lp://staging/powerd

  1. filter-proximity
  2. Merge into trunk
Proposed by Michael Frey
Status: Rejected
Rejected by: Ricardo Salveti
Proposed branch: lp://staging/~mfrey/powerd/filter-proximity
Merge into: lp://staging/powerd
Diff against target: 15 lines (+6/-0)
1 file modified
src/powerd-sensors.cpp (+6/-0)
To merge this branch: bzr merge lp://staging/~mfrey/powerd/filter-proximity
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ricardo Salveti (community) Needs Fixing
Review via email: mp+237338@code.staging.launchpad.net

Commit message

Filter out first proximity event as it sometimes contains the incorrect sensor state.

Description of the change

Filter out first proximity event as it sometimes contains the incorrect sensor state.
Fixes bugs #1378012 and #1378043

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:143
http://jenkins.qa.ubuntu.com/job/powerd-ci/164/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/powerd-utopic-armhf-ci/16
        deb: http://jenkins.qa.ubuntu.com/job/powerd-utopic-armhf-ci/16/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/powerd-ci/164/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ricardo Salveti (rsalveti) :
review: Needs Fixing
lp://staging/~mfrey/powerd/filter-proximity updated
144. By Michael Frey

Change warn to debug output

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:144
http://jenkins.qa.ubuntu.com/job/powerd-ci/166/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/powerd-utopic-armhf-ci/18
        deb: http://jenkins.qa.ubuntu.com/job/powerd-utopic-armhf-ci/18/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/powerd-ci/166/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

While testing I noticed that if I start a call with something covering up the proximity sensor, the screen will never be off, which might be a side effect of this change.

I wonder if it might be better to work instead fixing the sensor for this hardware specifically, for it to always give a valid value when doing the first read. I know bug #1378043 is actually a side effect of doing the screen handling on powerd and not as part of the phone stack (if the screen gets off before the call starts, the phone will lock itself).

review: Needs Fixing
lp://staging/~mfrey/powerd/filter-proximity updated
145. By Michael Frey

Delay enable of prox sensor rather than filter

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:145
http://jenkins.qa.ubuntu.com/job/powerd-ci/167/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/powerd-utopic-armhf-ci/19
        deb: http://jenkins.qa.ubuntu.com/job/powerd-utopic-armhf-ci/19/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/powerd-ci/167/rebuild

review: Approve (continuous-integration)
lp://staging/~mfrey/powerd/filter-proximity updated
146. By Michael Frey

reduce the delay to .5 sec

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:146
http://jenkins.qa.ubuntu.com/job/powerd-ci/168/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/powerd-utopic-armhf-ci/20
        deb: http://jenkins.qa.ubuntu.com/job/powerd-utopic-armhf-ci/20/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/powerd-ci/168/rebuild

review: Approve (continuous-integration)
lp://staging/~mfrey/powerd/filter-proximity updated
147. By Michael Frey

bump delay

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:147
http://jenkins.qa.ubuntu.com/job/powerd-ci/169/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/powerd-utopic-armhf-ci/21
        deb: http://jenkins.qa.ubuntu.com/job/powerd-utopic-armhf-ci/21/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/powerd-ci/169/rebuild

review: Approve (continuous-integration)

Unmerged revisions

147. By Michael Frey

bump delay

146. By Michael Frey

reduce the delay to .5 sec

145. By Michael Frey

Delay enable of prox sensor rather than filter

144. By Michael Frey

Change warn to debug output

143. By Michael Frey <michael@michael-MacBookAir>

Filter out first proximity event to aviod incorrect reading

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches